Skip to content

feat(validate): add --type to catch workflows that cannot build for t… - #697

Open
yadavchiragg wants to merge 1 commit into
ControlCore-Project:devfrom
yadavchiragg:feat/validate-type
Open

yadavchiragg wants to merge 1 commit into
ControlCore-Project:devfrom
yadavchiragg:feat/validate-type

Conversation

@yadavchiragg

Copy link
Copy Markdown

Problem

mkconcore.py exits with "cannot pull container X with control core type posix" when a node label has no file extension (a pulled container, e.g. CZ:cpymat) and the type is posix or windows. concore validate passes these workflows, so the failure only shows up at build time. Affected bundled workflows: testsou/testPull.graphml, testPullM.graphml, ratc/yuoctshMPull.graphml.

Change

concore validate --type windows|posix|docker

  • with posix/windows, pulled containers are reported as errors with a message pointing at --type docker
  • without --type behavior is unchanged
  • deliberately limited to this one rule: the supported-extension list lives in mkconcore.py and changes with other PRs, so it is not duplicated here

Testing

  • tests/test_validate_exec_type.py (5 tests)
  • compared with mkconcore.py on all 129 bundled workflows for posix and windows: validate flags exactly the 6 workflow/type pairs that mkconcore rejects with "cannot pull container" (no extras, no misses)
  • existing validate/CLI tests unchanged, ruff clean

Docs

Added --type to the validate section of concore_cli/README.md

…hat execution type

mkconcore.py exits with 'cannot pull container' when a node has no file extension and the type is posix or windows, but concore validate passed such workflows. validate --type posix|windows now reports pulled containers as errors up front. Without --type nothing changes. Checked against mkconcore on every bundled workflow: same 6 workflow/type pairs, no differences. Tests and docs included.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant