Repository navigation
feat(validate): add --type to catch workflows that cannot build for t… - #697
Open
yadavchiragg wants to merge 1 commit into
Open
yadavchiragg wants to merge 1 commit into
yadavchiragg wants to merge 1 commit into
Conversation
…hat execution type mkconcore.py exits with 'cannot pull container' when a node has no file extension and the type is posix or windows, but concore validate passed such workflows. validate --type posix|windows now reports pulled containers as errors up front. Without --type nothing changes. Checked against mkconcore on every bundled workflow: same 6 workflow/type pairs, no differences. Tests and docs included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mkconcore.py exits with "cannot pull container X with control core type posix" when a node label has no file extension (a pulled container, e.g.
CZ:cpymat) and the type is posix or windows.concore validatepasses these workflows, so the failure only shows up at build time. Affected bundled workflows: testsou/testPull.graphml, testPullM.graphml, ratc/yuoctshMPull.graphml.Change
concore validate --type windows|posix|docker--type docker--typebehavior is unchangedTesting
Docs
Added
--typeto the validate section of concore_cli/README.md